Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Matroska mapping #49

Merged
merged 1 commit into from Feb 11, 2017
Merged

add Matroska mapping #49

merged 1 commit into from Feb 11, 2017

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Feb 11, 2017

No description provided.

@dericed
Copy link
Contributor Author

dericed commented Feb 11, 2017

@JeromeMartinez
Copy link
Contributor

I think that the "V_MS/VFW/FOURCC" part should not be there: content of the paragraph about the ConfigurationRecord position is already in the AVI part, and "V_MS/VFW/FOURCC" part in Matroska is for AVI compatibility.
Here, I see a mix of Matroska and AVI details in the same paragraph, not good.

I suggest that the 2nd paragprah of FFV1 in Matroska is removed, alternatively with the BITMAPINFOHEADER part as another PR about extending AVI part.

@dericed
Copy link
Contributor Author

dericed commented Feb 11, 2017

updated per @JeromeMartinez's comments, though I want to be sure that someone using this spec to interpret ffv1 in mkv, doesn't ignore all the legacy mkv with ffv1 in VFW

@michaelni michaelni merged commit 6e9c3e0 into FFmpeg:master Feb 11, 2017
@michaelni
Copy link
Member

Maybe you want to add some text mentioning VFW

@JeromeMartinez JeromeMartinez deleted the ffv1-in-mkv branch January 3, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants